factorize out choice of plane, use it for loopers as well

[VinInn]

#7218 tried to cure the symptoms.

This shall cure the cause!

minor regressions expected.
none observed on 2012 data...

[cmsbuild]

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_5_X.

factorize out choice of plane, use it for loopers as well

It involves the following packages:

TrackingTools/GeomPropagators

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @bellan, @gpetruc, @cerati, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[davidlange6]

@cmsbuild, please test

On Feb 22, 2015, at 11:33 AM, cmsbuild <notifications@github.commailto:notifications@github.com> wrote:

A new Pull Request was created by @VinInnhttps://github.com/VinInn (Vincenzo Innocente) for CMSSW_7_5_X.

factorize out choice of plane, use it for loopers as well

It involves the following packages:

TrackingTools/GeomPropagators

@cmsbuildhttps://github.com/cmsbuild, @cvuosalohttps://github.com/cvuosalo, @nclopezohttps://github.com/nclopezo, @slava77https://github.com/slava77 can you please review it and eventually sign? Thanks.
@makortelhttps://github.com/makortel, @GiacomoSguazzonihttps://github.com/GiacomoSguazzoni, @roverehttps://github.com/rovere, @VinInnhttps://github.com/VinInn, @appeltelhttps://github.com/appeltel, @bellanhttps://github.com/bellan, @gpetruchttps://github.com/gpetruc, @ceratihttps://github.com/cerati, @dgulhanhttps://github.com/dgulhan, @venturiahttps://github.com/venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezohttps://github.com/nclopezo, @ktfhttps://github.com/ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/7896#issuecomment-75429136.

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 18b28e8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7896/2807/summary.html

[cvuosalo]

Running extended tests...

[cvuosalo]

+1

for [#7896] 18b28e8

This PR involves a small code change related to the reconstruction of loopers.
It is expected to create some minor differences.

The code changes are satisfactory.

The following plots (PR in red, baseline in black) show very small differences from baseline CMSSW_7_5_X_2015-02-21-1400 in extended test results from workflow
25202.0_TTbar_13+TTbar_13INPUT+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15.


The Jenkins tests and extended tests of other workflows also show
many small, insignificant differences from baseline.
This PR produces no significant differences in processing time.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[davidlange6]

+1