bugfix for ConversionTools

[matteosan1]

Same as 7917 but for 74X. Bug fix in ConversionTools; one function call was missing a parameter.

On line 313 the call:
hasMatchedConversion(*it,convCol,beamspot,lxyMin,probMin,nHitsBeforeVtxMax)
When *it is a reco::GsfElectron (L305), the called function is
defined in line 51-52 of the header.
The function prototype for this version, expects the 4th argument to be
"bool allowCkfMatch" but in the function call this parameter is missing
(or, rather, the value of lxyMin is passed in this spot).
Since "float" can be cast to "bool" and "unsigned int" can be cast to "float",
it will compile but the behavior will not be what is expected.

After the fix we expect to see slightly more photons not passing the electron veto i.e. passElectronVeto()==0
(in gamma+Jet sample I see the percentage going from 7.7% to 8.0%).

[cmsbuild]

A new Pull Request was created by @matteosan1 (Matteo Sani) for CMSSW_7_4_X.

bugfix for ConversionTools

It involves the following packages:

RecoEgamma/EgammaTools

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: f5fd722
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7918/2861/summary.html

[cvuosalo]

+1
For #7918 f5fd722

A very small code change of adding an optional parameter to a function call. It should not cause any differences for standard workflows. Same as #7917, which is targeted for 75X.

The code change is satisfactory. Jenkins tests against baseline CMSSW_7_4_X_2015-02-25-1400 show no significant differences, as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

[davidlange6]

+1