Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bunchspacing eras to the newer versions #7926

Merged
merged 3 commits into from Feb 26, 2015

Conversation

mark-grimes
Copy link

This pull request does two things, mainly just clearing up some old code:

  • Moves the old bunchspacing25ns era to run2_25ns_specific (and same for 50ns versions).
  • Stops cmsDriver trying to auto-detect the bunchspacing era from the --pileup option. User has to explicitly decide when choosing either --era Run2_25ns or --era Run2_50ns (can also choose Run2_HI but that's not relevant to this PR).

In principle this should be the last PR to replace the customisePostLS1 customisation, barring fixes for bugs found during validation. Validation will be presented in the 26/Feb/2015 reco meeting.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_7_4_X.

Change bunchspacing eras to the newer versions

It involves the following packages:

Configuration/Applications
Configuration/StandardSequences
SimGeneral/MixingModule

@civanch, @nclopezo, @mdhildreth, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @wmtan, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

Congrats on the era migration!

@mark-grimes
Copy link
Author

@Dr15Jones

In principle this should be the last PR...

"In principle" is a pretty big caveat.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants