-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup custom #7935
Cleanup custom #7935
Conversation
The FFTJetCorrector is accessible via the EventSetup and therefore all its const methods must be thread safe. Previously, the const method 'correct' was using a member data for a temporary buffer which was being changes on each call to 'correct'. To make the routine thread safe we now use a buffer on the stack if only a small buffer is needed and use a std::vector if a larger buffer is needed. This problem was caught by the static analyzer.
…the SeedCreatorPSet
…r in Phase1 tracking configuration Following what was done in cms-sw#1063.
To be more consistent with e.g. trajectory builders and filters, and we eventually will have to use it for HLT.
…umberingGeometry_cfi'
…onable eta binning in RE3/1 and RE4/1
…an be determined from the subdetector type
Removed the configuration parameter upgradeGeometry since its value can ...
… with reco::Photon functions
Fix for consumes interface in SimGeneral/MixingModule
…Digi Add consumes interface for GctDigiToRaw
…nder Add consumes interface for CSCTFTrackProducer
remove unnecessary static flag
fix runIsComplete behaviour for express processing
A new Pull Request was created by @wulsin for CMSSW_7_4_X. Cleanup custom It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @franzoni, @ktf, @cvuosalo, @boudoul, @ianna, @mdhildreth, @monttj, @cmsbuild, @srimanob, @nclopezo, @deguio, @slava77, @danduggan, @vadler, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. |
@wulsin , please, switch this PR to 7_5_X - you can do this in this page directly. The problem happens because so far 7_4_X is the default. |
Set the antiparticle decay table. Add comments to the s_spin function for clarity for developers. Remove unnecessary endl from MessageLogger statements.