Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup custom #7935

Closed
wants to merge 112 commits into from
Closed

Cleanup custom #7935

wants to merge 112 commits into from

Conversation

wulsin
Copy link
Contributor

@wulsin wulsin commented Feb 24, 2015

Set the antiparticle decay table. Add comments to the s_spin function for clarity for developers. Remove unnecessary endl from MessageLogger statements.

Wells Wulsin and others added 30 commits February 11, 2015 05:51
The FFTJetCorrector is accessible via the EventSetup and therefore
all its const methods must be thread safe. Previously, the const
method 'correct' was using a member data for a temporary buffer
which was being changes on each call to 'correct'. To make the
routine thread safe we now use a buffer on the stack if only a small
buffer is needed and use a std::vector if a larger buffer is needed.

This problem was caught by the static analyzer.
…r in Phase1 tracking configuration

Following what was done in cms-sw#1063.
To be more consistent with e.g. trajectory builders and filters, and
we eventually will have to use it for HLT.
Removed the configuration parameter upgradeGeometry since its value can ...
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wulsin for CMSSW_7_4_X.

Cleanup custom

It involves the following packages:

Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
DataFormats/Common
DataFormats/MuonDetId
DataFormats/PatCandidates
DataFormats/Provenance
DetectorDescription/Core
DetectorDescription/RegressionTest
EventFilter/CSCRawToDigi
EventFilter/GctRawToDigi
FWCore/Framework
Geometry/CMSCommonData
Geometry/CSCGeometry
Geometry/CommonDetUnit
Geometry/MuonCommonData
Geometry/MuonSimData
Geometry/RPCGeometry
Geometry/RPCGeometryBuilder
Geometry/TrackerGeometryBuilder
HLTriggerOffline/Higgs
IOPool/Streamer
JetMETCorrections/FFTJetModules
JetMETCorrections/FFTJetObjects
L1Trigger/CSCTrackFinder
RecoJets/JetProducers
RecoLocalMuon/CSCSegment
RecoPixelVertexing/PixelTriplets
RecoTracker/ConversionSeedGenerators
RecoTracker/IterativeTracking
SLHCUpgradeSimulations/Configuration
SLHCUpgradeSimulations/Geometry
SimCalorimetry/EcalTrigPrimProducers
SimG4Core/CustomPhysics
SimGeneral/MixingModule
SimMuon/GEMDigitizer
SimTracker/TrackerMaterialAnalysis
Utilities/StaticAnalyzers

@civanch, @Dr15Jones, @franzoni, @ktf, @cvuosalo, @boudoul, @ianna, @mdhildreth, @monttj, @cmsbuild, @srimanob, @nclopezo, @deguio, @slava77, @danduggan, @vadler, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @rappoccio, @yslai, @abbiendi, @TaiSakuma, @argiro, @Martin-Grunewald, @threus, @venturia, @mmarionncern, @battibass, @makortel, @cerati, @trocino, @barvic, @wmtan, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @nhanvtran, @schoef, @dgulhan, @wddgit, @appeltel, @ahinzmann, @gpetruc, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented Feb 24, 2015

@wulsin , please, switch this PR to 7_5_X - you can do this in this page directly. The problem happens because so far 7_4_X is the default.

@wulsin
Copy link
Contributor Author

wulsin commented Feb 24, 2015

@civanch Ok, I made a new PR into 7_5_X: #7936. Can I cancel this PR (7935)?

@wulsin wulsin closed this Feb 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment