Add consumes interface for SimHitTPAssociationProducer. #7971
Conversation
|
A new Pull Request was created by @wmtan for CMSSW_7_5_X. Add consumes interface It involves the following packages: SimGeneral/TrackingAnalysis @cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks. |
wmtan
changed the title
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
| edm::Handle<edm::PSimHitContainer> PSimHitCollectionH; | ||
| iEvent.getByLabel(*psit, PSimHitCollectionH); | ||
| iEvent.getByLabel(psit, PSimHitCollectionH); |
There was a problem hiding this comment.
Forgive my ignorance, but aren't we supposed to switch to getByToken in addition to declaring the consumes in the constructor?
There was a problem hiding this comment.
Yes. However, I am doing the consumes migration centrally for many packages. Working in this mode at this scale, it is much faster to just do the consumes part so I don't have to be switching gears. If the powers that be wish, I can do the migration to getByToken after the consumes part is finished.
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
|
I agree with Marco. Is easiest to make both migrations at once unless the code is particularly complex. |
|
+1 |
Add consumes interface for SimHitTPAssociationProducer.
Add the consumes interface for SimHitTPAssociationProducer.
Also changed one loop to a range for loop for consistency, clarity and maintainability.