DAF update

[ebrondol]

Following changes in the DAF implementation:

• changed name collection
• solved bug for 1D hits
• propagate algo and quality track info
• saved tracks changed before and after DAF into two different subcollections
• computed different chi2 for 1D and 2D hits

[slava77]

myTraj is not used?

[slava77]

Hi Erica,

Were these updates presented in the tracking POG already?
It would be nice to see a summary of changes in performance.

[slava77]

Does this config still run in 75X?

[slava77]

For run1 MC with pileup I needed to make the following changes

-process.load('Configuration/StandardSequences/Geometry_cff')
+process.load('Configuration.StandardSequences.GeometryRecoDB_cff')

...
-process.load("Configuration.StandardSequences.FrontierConditions_GlobalTag_cff")
-#from Configuration.AlCa.GlobalTag import GlobalTag
-#process.GlobalTag = GlobalTag(process.GlobalTag, 'auto:startup', '')
-process.GlobalTag.globaltag = 'START71_V1::All'#POSTLS171_V1::All'
+process.load('Configuration.StandardSequences.FrontierConditions_GlobalTag_condDBv2_cff')
+from Configuration.AlCa.GlobalTag_condDBv2 import GlobalTag
+process.GlobalTag = GlobalTag(process.GlobalTag, 'auto:run1_mc', '')

[slava77]

+1

for #7981 e83642d
tested in CMSSW_7_4_0_pre8 /test area sign523/

The code is not enabled by default, so, it's not introducing any changes in the standard workflows.

Please check the static analyzer issues in the DAF code

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7981/2973/llvm-analysis/report-499a10.html#EndPath

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7981/2973/llvm-analysis/

I ran tests on ttbar with run-1 pileup setup:

• there seem to be a memory leak of ~0.6 MB per event
• TracksDAF takes 2.3 s /event. About the same still as in my last tests of this back in July in Deterministic Annealing Filter for track reconstruction #4205

as the last time, the comments are expected to be addressed in follow up pull requests by the time this code gets (closer) to production quality.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[makortel]

The memory leak pointed in @slava77's first link is fixed in #7983.

[davidlange6]

+1

[ebrondol]

Hi @slava77 ,
I will wait to do the commented changes in 750_pre1 if it is ok.
Moreover, there are no differences in performance. I will prepare a short slide for the next POG.
Thanks a lot,
Erica