Fix RecoParticleFlow producers as reported by static analyser

[diguida]

Technical bug fixes already proposed in 73X as part of #7941

• In RecoParticleFlow/PFClusterProducer/src/PFClusterEMEnergyCorrector.cc added a guard against dividing by 0, in case some bug in the future might allow reco::PFCluster::energy() to return a 0 value;
• In RecoParticleFlow/PFProducer/src/PFAlgo.ccremoved not needed calculation within a loop.

[cmsbuild]

A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_7_5_X.

Fix RecoParticleFlow producers as reported by static analyser

It involves the following packages:

RecoParticleFlow/PFClusterProducer
RecoParticleFlow/PFProducer

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[diguida]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 6a10a2c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7998/2987/summary.html

[slava77]

+1

for #7998 6a10a2c
the code changes were approved already as a part of #7941
jenkins tests here confirm there are no changes in monitored outputs

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[davidlange6]

+1