New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLHAs from Shih-Chuan #8007
SLHAs from Shih-Chuan #8007
Conversation
A new Pull Request was created by @dnash86 for CMSSW_5_3_X. SLHAs from Shih-Chuan It involves the following packages: Configuration/Generator @vciulli, @covarell, @thuer, @cmsbuild, @nclopezo, @bendavid can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar, @ktf |
@davidlange6 , the mechanism to inline the slha tables in the fragments was not backported to pythia6 nor to 53x (and in addition 53x predates the migration of these to externals), so I think they're needed directly in the release as such. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar, @ktf |
hold |
@davidlange6 @dnash86 Done, the PR in cmsdist is here: cms-sw/cmsdist#1457. Please check that the cms-data repository containing those files matches the files that would have gone in this PR. The version has been done at this commit: cms-data/Configuration-Generator@88f6b60 |
Uh, I'm confused. I thought the migration to external data package was only done in the 7x release series, and for 53x we were still adding these files directly to the release. |
@bendavid- not sure - there is no real advantage to doing so aside from enabling a quick patch release, which is not the case here. |
Hi, So it seems to me that triggered by 61 extra files, we have backported a large change from 7x to 53x without discussing it, and without doing it consistently. |
@bendavid @davidlange6 I've created and merged a new PR for cmsdist that points to those 61 files only: cms-sw/cmsdist#1461. |
Thanks @Degano. I'll close this PR then as it should not be needed. |
SLHA files received from Shih-Chuan for Summer12 EXO request