New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration of the new SiPhase2Clusterizer in CMSSW #8032
Integration of the new SiPhase2Clusterizer in CMSSW #8032
Conversation
A new Pull Request was created by @thomaslenzi (Thomas Lenzi) for CMSSW_6_2_X_SLHC. Integration of the new SiPhase2Clusterizer in CMSSW It involves the following packages: SLHCUpgradeSimulations/Configuration The following packages do not have a category, yet: SimTracker/SiPhase2Digitizer @cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks. |
// Objects that will be produced | ||
produces< Phase2TrackerCluster1DCollectionNew >(); | ||
// | ||
clusterizer_ = new Phase2TrackerClusterizerAlgorithm(maxClusterSize_, maxNumberClusters_); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This memory is never released. Either change clusterizer_ to a std::unique_ptr or delete it in the destructor.
merge |
Pull request #8032 was updated. @cmsbuild, @civanch, @nclopezo, @mdhildreth can you please check and sign again. |
Integration of the new SiPhase2Clusterizer in CMSSW
Updated version of the Outer Tracker Clusterizer for the Phase2 Upgrade Simulations: