New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transient vector bugfix #8061
Transient vector bugfix #8061
Conversation
A new Pull Request was created by @andrewj314 (AJ Johnson) for CMSSW_7_4_X. Transient vector bugfix It involves the following packages: DataFormats/TauReco @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
Hi @slava77 , can we backport this PR also to 72x ? (it is being used for Phys14 studies and it is there where the problem originally appeared) |
I guess you'd want this to be in 73X as well. Please clarify where the issue appears. I suggest to make PRs, we can sign off depending on implications. |
It affects the analysis workflows (only when one uses fwlite to run analysis on miniAODs). Actually, for this particular analysis it is a blocker as it prevents usage of fwlite to analyze tau strips, so analysts must write c++ code. The other problem is that the problem does not signalize itself at all and only after careful inspection we found that there are actually buggy results. So the motivation would be to prevent such a buggy results for other unaware users. @andrewj314 Can you prepare PR's for 72x and 73x ? |
You bet! I'm on it. On Thu, Mar 5, 2015 at 2:52 PM, Pavel Jez notifications@github.com wrote:
|
ok, changes with effects on cases only downstream should be easier to propagate |
+1 |
…ondattempt Transient vector bugfix
Bugfix: Added ioread rules to clear transient vectors in DataFormats/TauReco/src/classes_def_2.xml
Hypernews: https://hypernews.cern.ch/HyperNews/CMS/get/physTools/3315/1/1.html