Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transient vector bugfix #8061

Merged

Conversation

andrewj314
Copy link
Contributor

Bugfix: Added ioread rules to clear transient vectors in DataFormats/TauReco/src/classes_def_2.xml

Hypernews: https://hypernews.cern.ch/HyperNews/CMS/get/physTools/3315/1/1.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2015

A new Pull Request was created by @andrewj314 (AJ Johnson) for CMSSW_7_4_X.

Transient vector bugfix

It involves the following packages:

DataFormats/TauReco

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@jpavel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cvuosalo
Copy link
Contributor

cvuosalo commented Mar 4, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@jpavel
Copy link
Contributor

jpavel commented Mar 5, 2015

Hi @slava77 , can we backport this PR also to 72x ? (it is being used for Phys14 studies and it is there where the problem originally appeared)

@slava77
Copy link
Contributor

slava77 commented Mar 5, 2015

I guess you'd want this to be in 73X as well.

Please clarify where the issue appears.
Is it affecting miniAOD workflows (the standard workflow now), or does it show up in more specific analysis tests?

I suggest to make PRs, we can sign off depending on implications.

@jpavel
Copy link
Contributor

jpavel commented Mar 5, 2015

It affects the analysis workflows (only when one uses fwlite to run analysis on miniAODs). Actually, for this particular analysis it is a blocker as it prevents usage of fwlite to analyze tau strips, so analysts must write c++ code. The other problem is that the problem does not signalize itself at all and only after careful inspection we found that there are actually buggy results. So the motivation would be to prevent such a buggy results for other unaware users.

@andrewj314 Can you prepare PR's for 72x and 73x ?

@andrewj314
Copy link
Contributor Author

You bet! I'm on it.

On Thu, Mar 5, 2015 at 2:52 PM, Pavel Jez notifications@github.com wrote:

It affects the analysis workflows (only when one uses fwlite to run
analysis on miniAODs). Actually, for this particular analysis it is a
blocker as it prevents usage of fwlite to analyze tau strips, so analysts
must write c++ code. The other problem is that the problem does not
signalize itself at all and only after careful inspection we found that
there are actually buggy results. So the motivation would be to prevent
such a buggy results for other unaware users.

@andrewj314 https://github.com/andrewj314 Can you prepare PR's for 72x
and 73x ?

Reply to this email directly or view it on GitHub
#8061 (comment).

@slava77
Copy link
Contributor

slava77 commented Mar 5, 2015

ok, changes with effects on cases only downstream should be easier to propagate

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants