Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete consumes interface for /HLTRechitInRegionsProducer #8081

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Mar 4, 2015

The consumes interface was previously implemented for HLTRechitInRegionsProducer, but two consumed products were omitted from the implementation. This pull request implements the consumes interface for those two products.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2015

A new Pull Request was created by @wmtan for CMSSW_7_5_X.

complete consumes interface for /HLTRechitInRegionsProducer

It involves the following packages:

RecoEgamma/EgammaHLTProducers

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@Sam-Harper, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

+1

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 5, 2015
complete consumes interface for /HLTRechitInRegionsProducer
@cmsbuild cmsbuild merged commit b38f7ec into cms-sw:CMSSW_7_5_X Mar 5, 2015
@wmtan wmtan deleted the ConsumesHLTRechitInRegionsProducer branch March 5, 2015 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants