Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cut that each tau has at least one pixel hits (for at least one of... #8095

Merged

Conversation

andrewj314
Copy link
Contributor

... the signal tracks),

in order to reduce increase of jet -> tau fake-rate observed for high pT jets in the Phys14 samples

… of the signal tracks),

in order to reduce increase of jet -> tau fake-rate observed for high pT jets in the Phys14 samples
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

A new Pull Request was created by @andrewj314 (AJ Johnson) for CMSSW_7_5_X.

added cut that each tau has at least one pixel hits (for at least one of...

It involves the following packages:

RecoTauTag/RecoTau

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@jpavel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Mar 5, 2015

@cmsbuild please test

@andrewj314 please add a link to slides or other documentation describing the physics impact of this change

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

@jpavel
Copy link
Contributor

jpavel commented Mar 5, 2015

@veelken, can you please provide some slides with the motivation for the fix and its impact?

@veelken
Copy link
Contributor

veelken commented Mar 6, 2015

Hi Pavel,

yes, of course. Arun will present the motivation and the effect on efficiency and fake-rate in the tau ID meeting on Monday.

Cheers,

Christian

@veelken
Copy link
Contributor

veelken commented Mar 9, 2015

@cvuosalo
Copy link
Contributor

+1

For #8095 895aafd

In Phys14 samples the tau fake rate increased around 5 times at some values of pT compared with 53X. Investigation showed that a cut of at least one pixel hit could eliminate most of this increased fake rate while preserving tau efficiency. This PR implements this new tau cut.

The code change is satisfactory, as are the Jenkins test results. Extended tests against baseline CMSSW_7_5_X_2015-03-05-0200 show no significant differences, except for the expected slight change in tau distributions. There is also a very small reduction (-0.35%, within the statistical uncertainty) in the ECAL converted photon efficiency for photons with ET > 20 GeV that appears in workflow 19.0_SingleGammaPt35+SingleGammaPt35. This tiny efficiency reduction is probably unrelated to this PR. Plots for these two effects are shown below.

Plots showing the decreased tau fake rate and unchanged tau efficiency are linked in this PR thread above.

Minor tau distribution changes (from workflow 25202 ttbar with PU):
all_testpr8095vsorig_ttbarpuwf25202p0c_recopftaus_pftausei__reco_obj_phi

Slight converted photon efficiency reduction:
onegammawf19p0select

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants