Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TH1F rather than TH1 as requested by ROOT6 #8097

Merged
merged 1 commit into from Mar 6, 2015
Merged

Use TH1F rather than TH1 as requested by ROOT6 #8097

merged 1 commit into from Mar 6, 2015

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Mar 5, 2015

No description provided.

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Mar 5, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_5_X.

More root6 backports

It involves the following packages:

PhysicsTools/Utilities

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ktf
Copy link
Contributor Author

ktf commented Mar 5, 2015

please test

@ktf ktf changed the title More root6 backports Use TH1F rather than TH1 as requested by ROOT6 Mar 5, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

The tests are being triggered in jenkins.

@davidlange6
Copy link
Contributor

@nclopezo - seems that the tests for this PR are stuck?

@nclopezo
Copy link
Contributor

nclopezo commented Mar 6, 2015

Hi David,

I restated them manually, they are running now.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2015

+1
Tested at: e2b754c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8097/3158/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8097/3158/summary.html

davidlange6 added a commit that referenced this pull request Mar 6, 2015
@davidlange6
Merge pull request #8097 from ktf/more-root6-backports
5292c2b 
Use TH1F rather than TH1 as requested by ROOT6
@davidlange6 davidlange6 merged commit 5292c2b into cms-sw:CMSSW_7_5_X Mar 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-available orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ktf @cmsbuild @davidlange6 @nclopezo