Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra dictionaries as requested by ROOT6. #8100

Merged
merged 1 commit into from Mar 5, 2015
Merged

Add extra dictionaries as requested by ROOT6. #8100

merged 1 commit into from Mar 5, 2015

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Mar 5, 2015

No description provided.

@ktf
Copy link
Contributor Author

ktf commented Mar 5, 2015

please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Mar 5, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_4_X.

Add extra dictionaries as requested by ROOT6.

It involves the following packages:

DataFormats/HcalDigi
DataFormats/HcalRecHit

@civanch, @nclopezo, @cvuosalo, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

+1
Tested at: c772663
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8100/3140/summary.html

@civanch
Copy link
Contributor

civanch commented Mar 5, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8100/3140/summary.html

davidlange6 added a commit that referenced this pull request Mar 5, 2015
@davidlange6
Merge pull request #8100 from ktf/more-root6-dictionaries
37acadf 
Add extra dictionaries as requested by ROOT6.
@davidlange6 davidlange6 merged commit 37acadf into cms-sw:CMSSW_7_4_X Mar 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available orp-pending pending-signatures reconstruction-pending simulation-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ktf @cmsbuild @civanch @davidlange6