Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrimaryVertex sorter fix and store of the score vector #8101

Merged
merged 2 commits into from Mar 6, 2015

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Mar 5, 2015

This PR fix a bug in the filling of the PV sorter association map and adds the requested feature of storing the score vector (the modified sumpt2)
This is also needed in 74X

@VinInn @gpetruc

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

A new Pull Request was created by @arizzi for CMSSW_7_5_X.

PrimaryVertex sorter fix and store of the score vector

It involves the following packages:

CommonTools/RecoAlgos

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@ahinzmann, @jdolen, @rappoccio this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Mar 5, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

@slava77
Copy link
Contributor

slava77 commented Mar 6, 2015

+1

for #8101 729108a
based on tests done towards approval of #8102

see details in #8102 (comment)
this is the same topic branch as in #8102

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants