Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron stream description #8112

Merged
merged 2 commits into from Mar 15, 2015

Conversation

rgerosa
Copy link
Contributor

@rgerosa rgerosa commented Mar 6, 2015

added fill description for SelectedElectronFEDListProducer in order to integrate electronStream in confDB.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2015

A new Pull Request was created by @rgerosa (raffaele gerosa) for CMSSW_7_5_X.

Electron stream description

It involves the following packages:

Calibration/EcalAlCaRecoProducers

@cmsbuild, @mmusich, @diguida, @cerminar, @nclopezo can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2015

edm::ParameterSetDescription desc;
desc.add<vector<edm::InputTag>>("electronTags",{edm::InputTag("hltEgammaGsfElectrons")});
desc.add<vector<edm::InputTag>>("recoEcalCandidateTags",{edm::InputTag("hltL1EG25Ele27WP85GsfTrackIsoFilter")});
desc.add<edm::FileInPath>("ESLookupTable",edm::FileInPath("EventFilter/ESDigiToRaw/data/ES_lookup_table.dat"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rgerosa Are the lookup tables for ES available in conditions via Global Tag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diguida, I have just sent an email to ECAL DB experts. I will let you know asap and, in case, I will update the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diguida https://github.com/diguida, experts say that there is not such tag for ES at the moment. Also the ESDigiToRaw used that “hardcoded” lookup table

Il giorno 09/mar/2015, alle ore 18:47, Salvatore Di Guida notifications@github.com ha scritto:

In Calibration/EcalAlCaRecoProducers/src/SelectedElectronFEDListProducer.cc #8112 (comment):

@@ -566,6 +569,35 @@ void SelectedElectronFEDListProducer<TEle,TCand>::pixelFedDump( std::vector<Pixe
return ;
}

+template< typename TEle, typename TCand>
+void SelectedElectronFEDListProducer<TEle,TCand>::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {

  • edm::ParameterSetDescription desc;
  • desc.add<vectoredm::InputTag>("electronTags",{edm::InputTag("hltEgammaGsfElectrons")});
  • desc.add<vectoredm::InputTag>("recoEcalCandidateTags",{edm::InputTag("hltL1EG25Ele27WP85GsfTrackIsoFilter")});
  • desc.addedm::FileInPath("ESLookupTable",edm::FileInPath("EventFilter/ESDigiToRaw/data/ES_lookup_table.dat"));
    @rgerosa https://github.com/rgerosa Are the lookup tables for ES available in conditions via Global Tag?


Reply to this email directly or view it on GitHub https://github.com/cms-sw/cmssw/pull/8112/files#r26058051.

@diguida
Copy link
Contributor

diguida commented Mar 14, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 15, 2015
@cmsbuild cmsbuild merged commit e6688d4 into cms-sw:CMSSW_7_5_X Mar 15, 2015
shervin86 pushed a commit to shervin86/cmssw that referenced this pull request May 11, 2015
shervin86 pushed a commit to shervin86/cmssw that referenced this pull request Jun 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants