Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test module that tags merged clusters per MC truth #8135

Merged
merged 1 commit into from Mar 12, 2015

Conversation

wmtford
Copy link
Contributor

@wmtford wmtford commented Mar 7, 2015

New plugin that tags clusters as merged if they are associated with more than one simTrack. This implements the functionality previously proposed as PR#8082, but touching only the /test/ and /python/test/ subdirectories of SiStripClusterizer.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2015

A new Pull Request was created by @wmtford for CMSSW_7_5_X.

Test module that tags merged clusters per MC truth

It involves the following packages:

RecoLocalTracker/SiStripClusterizer

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @forthommel, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @nickmccoll, @jlagram, @gpetruc, @cerati, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2015

@slava77
Copy link
Contributor

slava77 commented Mar 11, 2015

+1

for #8135 c7032ac
all code changes are in the test areas of RecoLocalTracker/SiStripClusterizer package;
the code changes are visually reasonable and jenkins compiles them fine.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

1 similar comment
@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants