New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add labelsFromToken function to event/lumi/run #8183
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_5_X. Add labelsFromToken function to event/lumi/run It involves the following packages: FWCore/Framework @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
+1 |
please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
+1 |
Add labelsFromToken function to event/lumi/run
This pull request adds a new function, labelsForToken() to the Event, LuminosityBlock, and Run. All the function does is call (indirectly) EDConsumerBase::labelsForToken().
The new functionality is needed for the consumes interface. In cases where getByToken() will be called from a helper function, there is currently no convenient way to get the module label, product instance name and process name for error messages if the getByToken() fails, or for that matter, for informational messages if it succeeds.
Please expedite testing this pull request, because much further development of the consumes interface depends on it.