Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron analyzer correction #8203

Merged
merged 1 commit into from Mar 13, 2015
Merged

Electron analyzer correction #8203

merged 1 commit into from Mar 13, 2015

Conversation

archiron
Copy link
Contributor

Lines https://github.com/cms-sw/cmssw/blob/CMSSW_7_5_X/DQMOffline/EGamma/plugins/ElectronAnalyzer.cc#L401-402 are uncommented.
matchingObject_Pt and matchingObject_Phi histos can be computed again.

tests with runTheMatrix.py and number 4.22 5.1 135.4 8.0 140.53 4.53 1306.0 101.0 1000.0 1001.0 1330.0 9.0 1003.0 25.0 25202.0 are OK.

@beaudett

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @archiron (Chiron) for CMSSW_7_5_X.

Electron analyzer correction

It involves the following packages:

DQMOffline/EGamma

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Mar 13, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 13, 2015
@cmsbuild cmsbuild merged commit 289069a into cms-sw:CMSSW_7_5_X Mar 13, 2015
@archiron archiron deleted the ElectronAnalyzerCorrection2 branch March 13, 2015 14:06
@archiron archiron restored the ElectronAnalyzerCorrection2 branch March 13, 2015 15:23
@archiron archiron deleted the ElectronAnalyzerCorrection2 branch May 20, 2015 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants