re-enable the kOutOfTime filtering in PF-rechits

[emanueledimarco]

1. kOutOfTime filtering is needed to complete the ECAL spike rejection together with the topological cuts

2. enable the usage of the ECAL rechits recovered in case of dead trigger towers (new algorithm for the recovery is in place)

@mariadalfonso @bachtis @argiro @cerminar @bendavid please also look at this

[cmsbuild]

A new Pull Request was created by @emanueledimarco (Emanuele Di Marco) for CMSSW_7_4_X.

re-enable the kOutOfTime filtering and TT recovery in PF-rechits

It involves the following packages:

RecoParticleFlow/PFClusterProducer

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[slava77]

I'm looking at our tests comparisons and so far, the change in 2) (the dead tower recovery) dominates the physics level changes.
I wish that this late we were receiving only changes that were identified and discussed as a follow up to validation.
Maybe I missed the part for the change for item 2).

@bachtis
?

[bachtis]

Hi, Which hits go into the selection is something we trust the DPG on. Now if we have a high level plot that shows worse behavior we can togther with them decide that we dont want thoise hits in..I understood it is a zero level change...Can someone tell me here what exactly those hits are ?

[bendavid]

Hi,
I would like to point out that TT recovery hits were also skipped even in 71x before the multifit went in. So this is an orthogonal change at least.
https://github.com/cms-sw/cmssw/blob/CMSSW_7_1_X/RecoParticleFlow/PFClusterProducer/python/particleFlowRecHitECAL_cfi.py

[cmsbuild]

+1
Tested at: bbb4a48
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8224/423/summary.html

[slava77]

+1

for #8224 359d1dc
tested in CMSSW_7_4_0_pre8 /test area sign528, cherry-picked/

With only the item (1), kOutOfTime filtering, the changes are fairly minimal. Differences show up only in data workflows and in MC with pileup (MC without pileup is unchanged).

Emanuele, please update the subject of the PR so that it doesn't suggest the TT recovery is applied

• Run2012B Photon PD
  There is a small reduction in the number of reduced ecal hits, corresponding to a few % reduction in the number of ECAL PF clusters, followed by a matching reduction in downstream pf/egamma objects (changes in ged photons and electrons as well as in pf candidates are small)
  
  

The number of Cleaned rechits goes up (expected for this change)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

[davidlange6]

+1