Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastsim fix ele track ref #8231

Merged
merged 3 commits into from Mar 13, 2015
Merged

Fastsim fix ele track ref #8231

merged 3 commits into from Mar 13, 2015

Conversation

lveldere
Copy link
Contributor

for description, see #8143

@davidlange6

I accidentally made a pr for 75 (#8143)
but we need this in 74 as well.

Lukas

Lukas added 3 commits March 9, 2015 09:32
Tracker-driven electron seeds are produced from the track collection before pile-up mixing,
because the algorithm depends on trajectories which are only available before mixing.
A new module, ElectronSeedTrackRefFix, is implented and inserted in the electron reconstruction sequence.
This modules makes a copy of the tracker-driven electron seeds while replaceing in each seed,
the reference to the "before mixing" tracks with a reference to the corresponding "after mixing" track.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lveldere for CMSSW_7_4_X.

Fastsim fix ele track ref

It involves the following packages:

FastSimulation/Configuration
FastSimulation/ParticleFlow
FastSimulation/Tracking

@ssekmen, @nclopezo, @lveldere, @civanch, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lveldere
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

davidlange6 added a commit that referenced this pull request Mar 13, 2015
@davidlange6 davidlange6 merged commit f38e107 into cms-sw:CMSSW_7_4_X Mar 13, 2015
cmsbuild added a commit that referenced this pull request Mar 16, 2015
FastSim PF electrons: fix gen-mixing after pr #8231
@lveldere lveldere deleted the fastsim-fix-eleTrackRef branch July 13, 2015 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants