New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary ROOT5/ROOT6 diffs in CondCore/IOVService #8240
Remove unnecessary ROOT5/ROOT6 diffs in CondCore/IOVService #8240
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_5_X. Remove unnecessary ROOT5/ROOT6 diffs in CondCore/IOVService It involves the following packages: CondCore/IOVService @diguida, @cerminar, @cmsbuild, @nclopezo, @ggovi, @mmusich can you please review it and eventually sign? Thanks. |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
+1 |
Remove unnecessary ROOT5/ROOT6 diffs in CondCore/IOVService
Some changes made to CondCore/IOVService in CMSSW_7_4_ROOT6_X should have also been made in CMSSW_7_4_X/7_5_X for code compatibility. This PR makes these changes in 7_5_X.
The changes are trivial, namely using the correct relative path to an included local header.