Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections for HCAL iterative phi symmetry calibration AlCaReco .py files #8286

Closed

Conversation

nilina
Copy link
Contributor

@nilina nilina commented Mar 13, 2015

3 python files were added for AlCaReco stream:
Calibration/HcalAlCaRecoProducers/python/ALCARECOHcalCalIterativePhiSym_Output_cff.py
Calibration/HcalAlCaRecoProducers/python/ALCARECOHcalCalIterativePhiSym_cff.py
Calibration/HcalAlCaRecoProducers/python/alcaiterphisym_cfi.py

and 1python file for testing:
Calibration/HcalAlCaRecoProducers/test/AlCaIterativePhiSym_cfg.py

No any corrections and changes for producers!

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nilina for CMSSW_7_5_X.

Corrections for HCAL iterative phi symmetry calibration AlCaReco .py files

It involves the following packages:

Calibration/HcalAlCaRecoProducers

@cmsbuild, @mmusich, @diguida, @cerminar, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Mar 23, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@mmusich
Copy link
Contributor

mmusich commented May 13, 2015

-1
@nilina this has still issues in list of commits.
May I suggest to close it and start from scratch starting from the lastest IB?
Thanks

@mmusich
Copy link
Contributor

mmusich commented May 13, 2015

superseded by #9075
@diguida thanks

@nclopezo nclopezo closed this May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment