New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing Duplications of some DD Algos #8327
Conversation
A new Pull Request was created by @boudoul (boudoul) for CMSSW_7_5_X. Removing Duplications of some DD Algos It involves the following packages: Geometry/TrackerCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks. |
Comparison is ready |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
@@ -13,7 +13,7 @@ | |||
#include "DetectorDescription/Core/interface/DDMaterial.h" | |||
#include "DetectorDescription/Core/interface/DDCurrentNamespace.h" | |||
#include "DetectorDescription/Core/interface/DDSplit.h" | |||
#include "SLHCUpgradeSimulations/Geometry/interface/DDPixBarLayerUpgradeAlgo.h" | |||
#include "Geometry/TrackerCommonData/plugins/DDPixBarLayerUpgradeAlgo.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually allow including across plugins?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind...
+1 |
Removing Duplications of some DD Algos
DD Algos were duplicated after the PR #7815
The ones duplicated for 2017 have then been removed from SLHCUpgradeSimulations/Geometry (the Geometry/TrackerCommonData is more adequate)
@rovere @VinInn @atricomi @venturia