Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variables to StoppedParticles 75X #8355

Merged

Conversation

jalimena
Copy link
Contributor

Add pdgId, mass, and charge to StoppedParticles, remove an extraneous mDebug parameter, and add the additional variables to RHStopDump.

@jalimena
Copy link
Contributor Author

These additional variables will be helpful for the two long-lived exotica searches that use the StoppedParticles, and it will make it easier to debug possible problems in the future. This PR is in addition to the bug fix of #8282, which was the minimum needed to fix the problem.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jalimena (Juliette Alimena) for CMSSW_7_5_X.

Add variables to StoppedParticles 75X

It involves the following packages:

SimG4Core/CustomPhysics

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented Mar 17, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Mar 18, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants