Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port back from ROOT6 IB for commonality (Core) #8361

Merged
merged 1 commit into from Mar 17, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Mar 17, 2015

This PR ports back simple changes made in CMSSW_7_4_ROOT6_X in the Core L2 category that are desirable or harmless for CMSSW_7_4_X, in order to increase code commonality. All affected files will be identical in the two releases after this PR is merged. Changes were successfully tested with the short relval matrix and unit test.
The changes are:

  1. An extra include needed for ROOT6.
  2. Code featured out by conditional compilation was changed to a comments.
  3. A "long long" was replaced by a more descriptive typedef.
  4. Macro exit codes used only in unit tests changed from 1 to 0. 0 is correct. Tests still pass.
  5. an unnecessary forward declaration was removed.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_4_X.

Port back from ROOT6 IB for commonality (Core)

It involves the following packages:

DataFormats/FWLite
FWCore/FWLite
IOPool/Output

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

ktf added a commit that referenced this pull request Mar 17, 2015
Port back from ROOT6 IB for commonality (Core)
@ktf ktf merged commit fd906a7 into cms-sw:CMSSW_7_4_X Mar 17, 2015
@wmtan wmtan deleted the PortBackFromROOT6IBCore branch March 18, 2015 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants