New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLHC: Full framework PFCanidate proxy builder drawing HGCal cells and envelope trapezoid #8369
Conversation
A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_6_2_X_SLHC. SLHC: Full frameworks proxy builder for HGCal candidate visualization It involves the following packages: Fireworks/FWInterface @cmsbuild, @alja, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @ktf, @fratnikov, @mark-grimes, @smuzaffar |
@vazzolini please watch this as well. |
@@ -80,7 +80,7 @@ class FWFFLooper : public CmsShowMainBase, public edm::EDLooperBase | |||
void requestChanges(const std::string &, const edm::ParameterSet &); | |||
|
|||
void remakeGeometry(const DisplayGeomRecord& dgRec); | |||
|
|||
static const edm::EventSetup* m_setup; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-const static class members are not multithread safe. Can EventSetup defined locally in the thread be delivered to the required consumers in the thread using parameters or other multithread safe means?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the presence of an EDLooper in a config automatically causes the framework to go into single threaded mode.
please test |
This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @ktf, @fratnikov, @mark-grimes, @smuzaffar |
An example of cmsRun configuration in full frameworks version of event display cmsShowFFHGCal.py: Start event display with cmsRun: |
This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @ktf, @fratnikov, @mark-grimes, @smuzaffar |
merge |
SLHC: Full framework PFCanidate proxy builder drawing HGCal cells and envelope trapezoid
Need to use FF to access reco geometry directly without conversion to fireworks format.