Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLHC: Full framework PFCanidate proxy builder drawing HGCal cells and envelope trapezoid #8369

Merged
merged 7 commits into from Mar 19, 2015

Conversation

alja
Copy link
Contributor

@alja alja commented Mar 17, 2015

Need to use FF to access reco geometry directly without conversion to fireworks format.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_6_2_X_SLHC.

SLHC: Full frameworks proxy builder for HGCal candidate visualization

It involves the following packages:

Fireworks/FWInterface

@cmsbuild, @alja, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@alja
Copy link
Contributor Author

alja commented Mar 17, 2015

screen shot 2015-03-02 at 4 25 59 pm

@alja
Copy link
Contributor Author

alja commented Mar 17, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @ktf, @fratnikov, @mark-grimes, @smuzaffar

@alja alja changed the title SLHC: Full frameworks proxy builder for HGCal candidate visualization SLHC: Full framework PFCanidate proxy builder drawing HGCal cells and envelope trapezoid Mar 17, 2015
@alja
Copy link
Contributor Author

alja commented Mar 17, 2015

@vazzolini please watch this as well.

@@ -80,7 +80,7 @@ class FWFFLooper : public CmsShowMainBase, public edm::EDLooperBase
void requestChanges(const std::string &, const edm::ParameterSet &);

void remakeGeometry(const DisplayGeomRecord& dgRec);

static const edm::EventSetup* m_setup;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-const static class members are not multithread safe. Can EventSetup defined locally in the thread be delivered to the required consumers in the thread using parameters or other multithread safe means?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the presence of an EDLooper in a config automatically causes the framework to go into single threaded mode.

@fratnikov
Copy link

please test

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @ktf, @fratnikov, @mark-grimes, @smuzaffar

@alja
Copy link
Contributor Author

alja commented Mar 19, 2015

An example of cmsRun configuration in full frameworks version of event display cmsShowFFHGCal.py:
https://gist.github.com/alja/6a67a2708c45af7faa28#file-cmsshowffhgcal-py

Start event display with cmsRun:
cmsRun cmsShowFFHGCal.py

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @ktf, @fratnikov, @mark-grimes, @smuzaffar

@fratnikov
Copy link

merge
suppose no more discussion is needed

cmsbuild added a commit that referenced this pull request Mar 19, 2015
SLHC: Full framework PFCanidate proxy builder drawing HGCal cells and envelope trapezoid
@cmsbuild cmsbuild merged commit 8de4c24 into cms-sw:CMSSW_6_2_X_SLHC Mar 19, 2015
@alja alja deleted the hgcalFF branch May 11, 2017 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants