Transition to Minuit2 for BeamSpotProducer

[menasce]

Backporting #8384

RecoVertex/BeamSpotProducer:
Certified transition from TVirtualFitter interface to Minuit2 for 3d beam spot fit. The fit now converges as used to in the old implementation.

People involved: @diguida and @mmusich

[cmsbuild]

A new Pull Request was created by @menasce for CMSSW_7_3_X.

Transition to Minuit2 for BeamSpotProducer

It involves the following packages:

RecoVertex/BeamSpotProducer

@nclopezo, @cvuosalo, @cerminar, @cmsbuild, @diguida, @slava77, @mmusich can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

Please clarify the needs for 73X release.
Are there any beam spot fits in CRAFT (probably not), or is it for some tests in MC?

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[mmusich]

@slava77 @cerminar these modules should be used in a Tier-0 replay for 2012 data in 73X

[cmsbuild]

+1
Tested at: d279697
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8385/3591/summary.html

[diguida]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[davidlange6]

+1