Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtVec.h: add long double x2 x4 in ExtVecTraits for AArch64 #8456

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Mar 22, 2015

The patch adds suport for long double vectors. This revealed GCC
bugs on i*86/x86_64/aarch64 (links below). Only done for AArch64,
as this would ICE GCC on x86_64 until fixed.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65486
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65491

Signed-off-by: David Abdurachmanov davidlt@cern.ch

The patch adds suport for long double vectors. This revealed GCC
bugs on i*86/x86_64/aarch64 (links below). Only done for AArch64,
as this would ICE GCC on x86_64 until fixed.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65486
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65491

Signed-off-by: David Abdurachmanov <davidlt@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_5_X.

ExtVec.h: add long double x2 x4 in ExtVecTraits for AArch64

It involves the following packages:

DataFormats/Math

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlt
Copy link
Contributor Author

davidlt commented Mar 22, 2015

There is no need for compile and similar tests as this file is not used on x86_64.

Merge made by the 'recursive' strategy.
 DataFormats/Math/interface/ExtVec.h | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
Switched to branch 'from-CMSSW_7_5_X_2015-03-19-2300'
>> Checking DataFormats/Math CMSSW_7_5_X_2015-03-19-2300
   x DataFormats/Math/interface/ExtVec.h
Checking out these packages: 0

I found only place in CMSSW (apart from tests) which actually uses long double (x2 and x4) vectors (aka Vec2 and Vec4): RecoMuon/TrackerSeedGenerator/interface/L1MuonPixelTrackFitter.h

   24 class L1MuonPixelTrackFitter : public PixelFitter {
     25
     26 public:
     27   class Circle {
     28   public:
     29     typedef Vector3DBase< long double, GlobalTag>  Vector;
     30     typedef  Point3DBase< long double, GlobalTag>  Point;

Lines 29-30.

@VinInn
Copy link
Contributor

VinInn commented Mar 22, 2015

L1MuonPixelTrackFitter should be modified to use plain double....

@slava77
Copy link
Contributor

slava77 commented Mar 23, 2015

+1

for #8456 fe1c2a1
the change affects only aarch64; it looks OK visually.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

davidlange6 added a commit that referenced this pull request Mar 23, 2015
…ors-aarch64

ExtVec.h: add long double x2 x4 in ExtVecTraits for AArch64
@davidlange6 davidlange6 merged commit 41769a2 into cms-sw:CMSSW_7_5_X Mar 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants