New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port back from ROOT6 IB for code commonality (Core again) #8474
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_4_X. Port back from ROOT6 IB for code commonality (Core again) It involves the following packages: DataFormats/Common @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
+1 |
Port back from ROOT6 IB for code commonality (Core again)
Port back more changes from 7_4_ROOT6_X in the Core L2 category that are beneficial or harmless for 7_4_X for code commonality. Six of the nine affected files will become identical between the two releases, while the other three, DataFormats/Provenance/src/classes_def.xml, FWCore/Modules/src/EventContentAnalyzer.cc, and FWCore/Utilities/src/TypeDemangler.cc, will still have some ROOT5/ROOT6 differences, but fewer than now.
Due to the current problems with frontier, I was unable to run the usual short relval matrix, but the unit tests for the affected packages all pass.