Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PFCluster Isolation to miniAOD electrons and photons (as #8221 , redone in 740pre9) #8501

Merged

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Mar 24, 2015

(copy-paste from #8221)

As the title says this PR add to floats to electron and photon to store PFCluster Isolation as computed at the HLT.
It contains:

  • Factorized isolation computation algorithm so that it can be run by the HLT and offline producers (RecoEgamma/EgammaIsolationAlgos). I have checked that HLT results stays the same.
  • Modified Electron.h and Photon.h DF to add the two numbers. (DataFormats/PatCandidates)
  • Updated PAT and MiniAOD configurations to store the value in the object. (PhysicsTools/PatAlgos)

The idea is to compute at RECO level the valuemap with the isolation values and propagate it to the miniAOD.
Right now the filling is not activated since we are missing the ValueMap into RECO relvals so it wouldn't pass the standard tests. I have privately checked the filling is ok.

@slava77
Copy link
Contributor Author

slava77 commented Mar 24, 2015

@cmsbuild
please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_7_4_X.

Add PFCluster Isolation to miniAOD electrons and photons (as #8221 , redone in 740pre9)

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos
RecoEgamma/Configuration
RecoEgamma/EgammaHLTProducers
RecoEgamma/EgammaIsolationAlgos
RecoEgamma/EgammaPhotonProducers

@perrotta, @cmsbuild, @nclopezo, @cvuosalo, @fwyzard, @monttj, @Martin-Grunewald, @slava77, @vadler can you please review it and eventually sign? Thanks.
@rappoccio, @Sam-Harper, @imarches, @ahinzmann, @acaudron, @mmarionncern, @lgray, @jdolen, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor Author

slava77 commented Mar 24, 2015

+1

for #8501 8f79371
this is the same code as signed off for #8221 29780dd
which diverged too much and needed a rebase

@Martin-Grunewald
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants