Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable MiniAOD validation, change GenJets to genJetsNoNu for default validation #8672

Conversation

webermat
Copy link
Contributor

@webermat webermat commented Apr 7, 2015

...validations.
Includes a fix for the previous PR #8504

The MiniAOD validation modules are now put in file
Configuration/StandardSequences/python/Validation_cff.py
into validationMiniAOD instead of the prevalidationMiniAOD sequence

Reorganisation for the MET Harvesting to include a PostProcessor for an overall MET Resolution summary plot and a MET PostProcessorHarvester to compare output of RECO and MiniAOD validations.

Tested successfully locally using the mentioned unscheduled Validation
runTheMatrix.py -l 11325 -i all

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2015

A new Pull Request was created by @webermat for CMSSW_7_5_X.

modifications to enable MiniAOD validation and compare RECO and MiniAOD ...

It involves the following packages:

Configuration/StandardSequences
Validation/Configuration
Validation/RecoJets
Validation/RecoMET

@civanch, @nclopezo, @cvuosalo, @mdhildreth, @cmsbuild, @franzoni, @deguio, @slava77, @danduggan, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @appeltel, @mmarionncern, @jdolen, @ahinzmann, @GiacomoSguazzoni, @rappoccio, @rovere, @VinInn, @Martin-Grunewald, @makortel, @nhanvtran, @schoef, @cerati, @mariadalfonso, @dgulhan, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2015

@slava77
Copy link
Contributor

slava77 commented May 26, 2015

I thought this PR was supposed to modify only miniAOD-related parts of the code, not the standard validation sequence.

Matthias, please update the PR subject and description (at the top of the PR page).
We should not bury default jet collection changes in seemingly unrelated PR names

@webermat webermat changed the title modifications to enable MiniAOD validation and compare RECO and MiniAOD ... enable MiniAOD validation, change GenJets to genJetsNoNu for default validation May 26, 2015
@slava77
Copy link
Contributor

slava77 commented May 26, 2015

+1

for #8672 10a17d1

  • compared to the last sign-off 5721562, input jet collections were changed in the standard validation sequence
  • jenkins tests pass ok; comparisons with the baseline show differences in jet plots as expected from the change in the jet collection input
  • tested workflow 11325 (it includes miniAOD) locally in CMSSW_7_5_X_2015-05-23-1100 /test area test8672/: miniAOD and jet validation plots have changed in a minor way (as expected for ak4GenJets -> ak4GenJetsNoNu switch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants