Hcal noise filters update #8685
Conversation
|
A new Pull Request was created by @igv4321 for CMSSW_7_5_X. Hcal noise filters update It involves the following packages: CommonTools/RecoAlgos @civanch, @nclopezo, @cvuosalo, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
| if(energy>=threshold) total+=energy; | ||
| } | ||
| return total; | ||
| } | ||
|
|
||
| float HcalNoiseHPD::recHitEnergyFailR45(float threshold) const | ||
| float HcalNoiseHPD::recHitEnergyFailR45(const float threshold) const |
There was a problem hiding this comment.
these changes from float to const float don't make any difference. Perhaps you meant to change to const float &?
There was a problem hiding this comment.
[I don't recall asking for this change, so, just my 2c notes on this]
const float& doesn't make much sense, it's less efficient than what it is now.
declaring something that's not supposed to be changed as a const is a good practice (in this case for the scope of the function, not for the users of the function).
There was a problem hiding this comment.
It is kind of in the spirit "Use const whenever possible" -- see item 21 in Scott Meyers' "Effective C++" book.
|
+1 |
Modifying HCAL noise filters per request from the HCAL noise group.
More details can be gathered from
https://indico.cern.ch/event/381507/contribution/1/material/slides/0.pdf