Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumes migration for CosmicGenFilterHelix #8734

Merged
merged 1 commit into from Apr 23, 2015

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Apr 14, 2015

Add consumes function calls for the module
CosmicGenFilterHelix. Convert getByLabel call
to getByToken.

Add consumes function calls for the module
CosmicGenFilterHelix. Convert getByLabel call
to getByToken.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_5_X.

Consumes migration for CosmicGenFilterHelix

It involves the following packages:

GeneratorInterface/GenFilters

@vciulli, @covarell, @thuer, @cmsbuild, @nclopezo, @bendavid can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8734/4242/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

davidlange6 added a commit that referenced this pull request Apr 23, 2015
Consumes migration for CosmicGenFilterHelix
@davidlange6 davidlange6 merged commit 8bcf1f8 into cms-sw:CMSSW_7_5_X Apr 23, 2015
@wddgit wddgit deleted the consumesCosmicGenFilterHelix branch July 6, 2015 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants