ECAL unpacker: consider the ADC hysteresis in the gain switches (back-port to 74X)

[emanueledimarco]

This is the back port to 7.4.X of the bug fix in the 7.5.X branch (PR #8759)

@grasph @argiro @ferriff please also follow this.

[cmsbuild]

A new Pull Request was created by @emanueledimarco (Emanuele Di Marco) for CMSSW_7_4_X.

ECAL unpacker: consider the ADC hysteresis in the gain switches (back-port to 74X)

It involves the following packages:

EventFilter/EcalRawToDigi

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 60b7752
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8760/4248/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

[slava77]

@cmsbuild @Degano @nclopezo
could you please investigate why validateJR directory has so few results:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_7_4_X_2015-04-16-1100+8760/4248/validateJR/
it's as if the area used for comparisons was full or the test area directories didn't get populated for some other reason.

Thank you.

[nclopezo]

Hi Slava,
It seems that there was a glitch while downloading the files. I restarted the comparison and it should run ok now.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8760/4248/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8760/4248/summary.html

[nclopezo]

The latest results are here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_7_4_X_2015-04-16-1100+8760/7201/

[davidlange6]

+1