Update PF hadron calibration code

[mmarionncern]

As decided in https://indico.cern.ch/event/388237/

change slightly the pseudorapidity dependency handlings
update also the default hardcoded calibration laws to match the last calibration uplaoded in the DB (hardcoded values are not used by the reco sequence)

[cmsbuild]

A new Pull Request was created by @mmarionncern for CMSSW_7_4_X.

Update PF hadron calibration code

It involves the following packages:

RecoParticleFlow/PFClusterTools

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

@mmarionncern
Please post a brief summary of the impact (as "response in eta changes by as much as xxx resolution yyy"
Thank you

[cmsbuild]

The tests are being triggered in jenkins.

[mmarionncern]

Summary of performances :

• hadron resolution : no significant changes
• EH-hadrons (EM & Had. energy) response in barrel flatter
• H-hadron response in endcap : improvement of the hadron response for low energy hadrons for 2.5<|eta|<3 (response moves from -30% to -10% in average. Bad response in that region is a general consequence of the lack of charged hadron outside the tracker acceptance), response for 2.3< |eta| < 2.5 moves from -2% to +2%

[cmsbuild]

-1
Tested at: ecf6d7b
When I ran the RelVals I found an error in the following worklfows:
8.0 step5

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step5_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8773/7204/summary.html

[slava77]

tested in CMSSW_7_4_0 /test area sign540/ including higher statistics tests.
The increase in neutral hadron response is the most visible change.

here are a few plots most sensitive to it (not the most available quantity in DQM)
ttbar events with PU neutral hadron fraction in MET:

ttbar with PU35@25 ns p vs pt combination of plots for neutral hadrons points to increase in the neutral hadron response in the forward region. The eta plot shows more clearly where.

on the higher level object side:
flat-pt dijet sample shows possibly decreased resolution in the barrel jets in the 200 to 600 GeV range
[could be partly binning effect, stats are low]

in ttbar with PU35@25 ns there is a slight decrease (?) in CHS jet response in the endcap at the low-ET edge

Overall, the main change is as expected;
additional higher order changes are inconclusive in terms of quality (improvement or not) with the stats of the tests performed.

I suppose it's a "+1", but I'll leave some time for comments.

[slava77]

+1

for #8773 ecf6d7b
[based on tests in CMSSW_7_4_0 /test area sign540/]
the low level changes appear to be as expected; the high level impact doesn't seem significant (based on the summary earlier in the thread)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

[davidlange6]

+1