Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer need AutoLibraryLoader for edmCheckClassVersion #8782

Merged
merged 1 commit into from Apr 20, 2015

Conversation

Dr15Jones
Copy link
Contributor

With ROOT 6 we no longer use the AutoLibraryLoader to load dictionaries. We now allow ROOT to do the loading itself.

With ROOT 6 we no longer use the AutoLibraryLoader to load dictionaries. We now allow ROOT to do the loading itself.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_5_X.

No longer need AutoLibraryLoader for edmCheckClassVersion

It involves the following packages:

FWCore/Utilities

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@wmtan
Copy link
Contributor

wmtan commented Apr 20, 2015

Since we still need the RootAutoLibraryLoader for ROOT5, i assume this PR should not be forward ported to CMSSW_7_5_ROOT5_X. Right, Chris?

@Dr15Jones
Copy link
Contributor Author

Yes, it is still needed in ROOT 5

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@Dr15Jones
Copy link
Contributor Author

+1

Please do not forward port to ROOT5 branch

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants