Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowing E/g HLT to be seeded by L1 jets #8804

Merged
merged 6 commits into from Apr 22, 2015

Conversation

Sam-Harper
Copy link
Contributor

Dear All,

This pull request has the necessary code to allow the E/g HLT paths to be seeded by L1 Jets. This is discussed in detail here. I have now confirmed that I can proceed with this so I'm doing so now.

This requires two changes. First it requires a new class, HLTRecHitInAllL1RegionsProducer which is a re-write of HLTRechitInRegionsProducer generalised to accept any combination of L1 seed types. This class is vital the E/g HLT to save time filters the rec-hits used by the PFclusters to be near L1 seeds. This class has been tested on ~30 million events and when configured identically to the old class, it gives identical results.

The second change is to allow the HLTEgammaL1MatchFilterRegional filter to also try to look for L1 jets. If the L1 seed module does not contain a jet seed, nothing will happen.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Sam-Harper for CMSSW_7_5_X.

allowing E/g HLT to be seeded by L1 jets

It involves the following packages:

HLTrigger/Egamma
RecoEgamma/EgammaHLTProducers

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

If you want this online in 2015, you need a 74X PR as well!

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants