Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reco material effects: updates to tools #8951

Merged
merged 13 commits into from May 5, 2015

Conversation

rovere
Copy link
Contributor

@rovere rovere commented May 4, 2015

This PR does not contain any new reco material XML, at least not in the proper folder/package. It is mainly intended to put in release all the new tools/development that was done in the process of deriving the improved material description.

Another PR will come that will contain the updated XML and that will likely be bundled to an update on the DB side.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2015

A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_7_5_X.

Reco material effects: updates to tools

It involves the following packages:

SimTracker/TrackerMaterialAnalysis

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @VinInn, @appeltel, @cerati, @threus, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@rovere
Copy link
Contributor Author

rovere commented May 4, 2015

FYI,
@VinInn @makortel @boudoul

@civanch
Copy link
Contributor

civanch commented May 4, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2015

The tests are being triggered in jenkins.

@civanch
Copy link
Contributor

civanch commented May 5, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants