New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JEC consumes for btag DQM #8952
JEC consumes for btag DQM #8952
Conversation
A new Pull Request was created by @acaudron for CMSSW_7_5_X. JEC consumes for btag DQM It involves the following packages: DQMOffline/RecoB @cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks. |
Comparison is ready The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
Is there an issue or are we waiting for something ? All the tests are fine so I'm not sure why we need to wait for going ahead with this PR. |
@davidlange6 @nclopezo @franzoni @deguio |
@davidlange6 @nclopezo @franzoni @deguio |
+1 |
@@ -41,3 +41,6 @@ | |||
HcalRemoveAddSevLevel.AddFlag(hcalRecAlgos,"HBHESpikeNoise",12) | |||
|
|||
CSCHaloData.ExpectedBX = cms.int32(3) | |||
|
|||
from JetMETCorrections.Configuration.JetCorrectors_cff import ak4PFCHSResidualCorrector, ak4PFCHSL1FastL2L3ResidualCorrector, ak4PFCHSL1FastL2L3ResidualCorrectorChain | |||
jetCorrectorsForReco.replace(ak4PFCHSL1FastL2L3CorrectorChain, ak4PFCHSL1FastL2L3ResidualCorrectorChain) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidlange6 these lines complete what have been done in the PR#8817 by @wddgit
Basically I need to have JEC for CHS jets for data (so including Residual correction) so I replace for data the Corrector Chain sequence to include this correction based on a suggestion from @slava77
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, residual corrections are available only in data GTs.
So, this is the only place where we can turn them on.
From RECO configuration perspective, I wish that instead dummy pass-through corrections were available in MC GT as well and we didn't have to modify configurations.
+1 |
Addapt btag DQM packages to JEC consumes.