Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JEC consumes for btag DQM #8952

Merged
merged 3 commits into from May 20, 2015

Conversation

acaudron
Copy link

@acaudron acaudron commented May 4, 2015

Addapt btag DQM packages to JEC consumes.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2015

A new Pull Request was created by @acaudron for CMSSW_7_5_X.

JEC consumes for btag DQM

It involves the following packages:

DQMOffline/RecoB
Validation/RecoB

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @rociovilar, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8952/4522/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@acaudron
Copy link
Author

Is there an issue or are we waiting for something ? All the tests are fine so I'm not sure why we need to wait for going ahead with this PR.

@wmtan
Copy link
Contributor

wmtan commented May 14, 2015

@davidlange6 @nclopezo @franzoni @deguio
Please expedite this PR. It is critical for the consumes interface for multithreading.
It's been sitting there for 6 days with no progress.

@wmtan
Copy link
Contributor

wmtan commented May 18, 2015

@davidlange6 @nclopezo @franzoni @deguio
Please expedite this PR. It is critical for the consumes interface for multithreading.
It's now been sitting there for 10 days unsigned with no progress.

@deguio
Copy link
Contributor

deguio commented May 19, 2015

+1
looks ok to me

@@ -41,3 +41,6 @@
HcalRemoveAddSevLevel.AddFlag(hcalRecAlgos,"HBHESpikeNoise",12)

CSCHaloData.ExpectedBX = cms.int32(3)

from JetMETCorrections.Configuration.JetCorrectors_cff import ak4PFCHSResidualCorrector, ak4PFCHSL1FastL2L3ResidualCorrector, ak4PFCHSL1FastL2L3ResidualCorrectorChain
jetCorrectorsForReco.replace(ak4PFCHSL1FastL2L3CorrectorChain, ak4PFCHSL1FastL2L3ResidualCorrectorChain)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acaudron - what is the need for these lines?

@slava77 , @cvuosalo

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidlange6 these lines complete what have been done in the PR#8817 by @wddgit
Basically I need to have JEC for CHS jets for data (so including Residual correction) so I replace for data the Corrector Chain sequence to include this correction based on a suggestion from @slava77

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, residual corrections are available only in data GTs.
So, this is the only place where we can turn them on.

From RECO configuration perspective, I wish that instead dummy pass-through corrections were available in MC GT as well and we didn't have to modify configurations.

@davidlange6
Copy link
Contributor

@acaudron, @slava77 - Thanks. @slava77, could you request that we start getting GTs like that, at the next ORP if not next AlCa meeting?

@davidlange6
Copy link
Contributor

+1

davidlange6 added a commit that referenced this pull request May 20, 2015
@davidlange6 davidlange6 merged commit a3a8ae6 into cms-sw:CMSSW_7_5_X May 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants