Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MultiTrackValidator performance #8988

Merged
merged 9 commits into from May 11, 2015

Commits on May 7, 2015

  1. Copy the full SHA
    6ac7481 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    cfbfab1 View commit details
    Browse the repository at this point in the history
  3. Tidy up dEdx treatment in MultiTrackValidator

    - Remove string comparisons
    - Remove copying of ValueMaps
    - Tidy up monitoring implementation
    
    Using the same ValueMap for all input track collections works for
    track validation, as all input collections are Refs to the original
    generalTracks.
    makortel committed May 7, 2015
    Copy the full SHA
    633d65c View commit details
    Browse the repository at this point in the history
  4. Tune TrackingParticleSelector for better performance

    - Break as soon as know that the return value is false
    - Reorder tests such that lighter ones are checked first
    - Reduce repeated calculations (minor)
    makortel committed May 7, 2015
    Copy the full SHA
    bccf672 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    77222d7 View commit details
    Browse the repository at this point in the history
  6. Cleanup in MultiTrackValidator

    Reduce repeated computations in
    - MTVHistoProducerAlgoForTracker::fill_simAssociated_recoTrack_histos()
    - MTVHistoProducerAlgoForTracker::fill_generic_recoTrack_histos()
    - MTVHistoProducerAlgoForTracker::fill_ResoAndPull_recoTrack_histos()
    
    Streamline MTVHistoProducerAlgoForTracker::fill_generic_recoTrack_histos(),
    plus other cleanups.
    makortel committed May 7, 2015
    Copy the full SHA
    18c5c28 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    3b64ba9 View commit details
    Browse the repository at this point in the history
  8. Precalculate (efficiency) TP momentum and vertex wrt PCA

    This reduces the amount of repeated calculations of those. Eliminating
    all repeated calculations would require fancier caching, or
    precalculating them for all TPs (such that they would be accessible
    through Refs, taking into account that label_tp_effic and
    label_tp_fake may point to different TP collections...).
    makortel committed May 7, 2015
    Copy the full SHA
    79c6629 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2015

  1. Fix clang compilation error

    makortel committed May 8, 2015
    Copy the full SHA
    af5504b View commit details
    Browse the repository at this point in the history