Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix strip DQM @HLT #8993

Merged

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented May 7, 2015

add ESProducer hltESPTTRHBWithTrackAngle and overwrite the TTRHBuilder parameter in the refitter module

this update is needed in order to make the code independent from the offline reconstruction sequence

@VinInn @rovere @fwyzard

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2015

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_7_5_X.

fix strip DQM @HLT

It involves the following packages:

DQMOffline/Trigger

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@rociovilar, @trocino, @jhgoh, @battibass this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2015

Pull request #8993 was updated. @cmsbuild, @danduggan, @nclopezo, @deguio can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2015

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request May 26, 2015
@cmsbuild cmsbuild merged commit ec739a2 into cms-sw:CMSSW_7_5_X May 26, 2015
wmtan pushed a commit to wmtan/cmssw that referenced this pull request May 27, 2015
wmtan pushed a commit to wmtan/cmssw that referenced this pull request May 27, 2015
wmtan pushed a commit to wmtan/cmssw that referenced this pull request May 28, 2015
wmtan pushed a commit to wmtan/cmssw that referenced this pull request May 29, 2015
wmtan pushed a commit to wmtan/cmssw that referenced this pull request May 29, 2015
wmtan pushed a commit to wmtan/cmssw that referenced this pull request May 29, 2015
wmtan pushed a commit to wmtan/cmssw that referenced this pull request May 30, 2015
wmtan pushed a commit to wmtan/cmssw that referenced this pull request May 30, 2015
wmtan pushed a commit to wmtan/cmssw that referenced this pull request Jun 1, 2015
@jmduarte
Copy link
Member

Hi @mtosi,

Was there ever a backport PR made for CMSSW_7_4_X?

Thanks,

Javier

@mtosi
Copy link
Contributor Author

mtosi commented Jun 12, 2015

ciao
I'm afraid nope
I'm not in front of the laptop, now
if you do not manage to do it, I'll try to do as soon as possible (it might be in the afternoon, but I cannot guarantee, sorry)
mia

On Jun 11, 2015, at 9:04 PM, Javier Duarte notifications@github.com wrote:

Hi @mtosi,

Was there ever a backport PR made for CMSSW_7_4_X?

Thanks,

Javier


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants