Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix associationMapFilterValues() for empty input AssociationMap #9000

Merged

Conversation

makortel
Copy link
Contributor

@makortel makortel commented May 8, 2015

Fixes the invalid reference exception from MultiTrackValidator in wfs 500207.0, 250207.0.

Tested in CMSSW_7_5_X_2015-05-07-1100 with limited matrix + wfs 500207.0, 250207.0. No changes expected in results.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2015

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_5_X.

Fix associationMapFilterValues() for empty input AssociationMap

It involves the following packages:

CommonTools/Utils

@nclopezo, @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented May 8, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2015

@cvuosalo
Copy link
Contributor

+1

For #9000 600394f

Small bug fix for an exception from associationMapFilterValues(). It should not change monitored physics quantities.

The code change is satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-05-07-2300 show no significant differences, as expected.

@makortel
Copy link
Contributor Author

ping

@davidlange6
Copy link
Contributor

bypassing a clear fix

davidlange6 added a commit that referenced this pull request May 15, 2015
Fix associationMapFilterValues() for empty input AssociationMap
@davidlange6 davidlange6 merged commit 7362447 into cms-sw:CMSSW_7_5_X May 15, 2015
@makortel makortel deleted the fix_associationMapFilterValues branch October 20, 2016 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants