Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Egamma/Electrons plots: separate +/- endcap for alignment,… #9010

Merged
merged 1 commit into from May 11, 2015

Conversation

gzevi
Copy link
Contributor

@gzevi gzevi commented May 8, 2015

DQMOffline plots for Egamma/Electrons are a bit out of date.
Starting here with some small fixes: add SigmaIetaIeta5x5 plots and PFIsolation plots (based on variables used in electron ID). Also separating positive and negative endcaps for alignment sensitive plots such as DeltaEta and DeltaPhi between track and supercluster.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2015

A new Pull Request was created by @gzevi for CMSSW_7_5_X.

Changes to Egamma/Electrons plots: separate +/- endcap for alignment,

It involves the following packages:

DQMOffline/EGamma

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented May 10, 2015

please test

@deguio
Copy link
Contributor

deguio commented May 10, 2015

+1
provided it passes the tests

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

once relvals in 750pre5 are ok, this one is good to be approved in 74x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants