Fix crash of workflow FS_SMS-T1tttt_mGl-1500_mLSP-100_13_PU25

[hengne]

Fix crash of workflow FS_SMS-T1tttt_mGl-1500_mLSP-100_13_PU25

[cmsbuild]

A new Pull Request was created by @hengne (Hengne Li) for CMSSW_7_5_X.

Fix crash of workflow FS_SMS-T1tttt_mGl-1500_mLSP-100_13_PU25

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @srimanob, @nclopezo, @boudoul, @franzoni can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[franzoni]

hello @hengne ,
can you pelase surface CMSSW_7_5_0_pre4-MCRUN2_75_V1_FastSim-v1 and place it into baseDataSetRelease, for ease of future updates ?
Thanks, G.

[franzoni]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[hengne]

Sure, but I don't quite understand what exactly does this mean and how to
do that?
could you please give me some more instructions? Thanks!

On Sat, May 9, 2015 at 7:09 PM, Giovanni Franzoni notifications@github.com
wrote:

hello @hengne https://github.com/hengne ,
can you pelase surface CMSSW_7_5_0_pre4-MCRUN2_75_V1_FastSim-v1 and place
it into baseDataSetRelease, for ease of future updates ?
Thanks, G.

—
Reply to this email directly or view it on GitHub
#9026 (comment).

[cmsbuild]

+1
Tested at: 12def7c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9026/7484/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
12def7c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9026/7484/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9026/7484/git-merge-result

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

[davidlange6]

@hengne - "fix" means remove in this case - what was the underlying problem that I guess there is no short term fix for? I have missed the discussion

[hengne]

On Tue, May 12, 2015 at 6:18 PM, David Lange notifications@github.com
wrote:

@hengne https://github.com/hengne - "fix" means remove in this case -
what was the underlying problem that I guess there is no short term fix
for? I have missed the discussion

@davidlange6 , no, it is not removing this case, it really fixed this
underlying bug, check these two lines:

https://github.com/hengne/cmssw/blob/from-CMSSW_7_5_0_pre4_relval_forMerge/Configuration/PyReleaseValidation/python/relval_steps.py#L801-L802

it fixed a typo in the codes, two letters "FS" were missing before in the
last string.

—
Reply to this email directly or view it on GitHub
#9026 (comment).

[davidlange6]

ok, I see - but then why comment out workflow 1337.1?

[hengne]

@davidlange6 , the new one 1337 'SMS-T1tttt_mGl-1500_mLSP-100_13' is designed to replace the old one 1337.1 'LM1_sfts_13', i.e. as Giovanni commented behind the following line:

https://github.com/hengne/cmssw/blob/from-CMSSW_7_5_0_pre4_relval_forMerge/Configuration/PyReleaseValidation/python/relval_steps.py#L390

" #steps['LM1_sfts_13INPUT']={'INPUT':InputInfo(dataSet='/RelValLM1_sfts_13/%s/GEN-SIM'%(baseDataSetRelease[3],),location='STD')}# to be removed, replaced by the following"

[davidlange6]

ok - could we just get rid of the lines altogether? Seems they won’t come back.

On May 12, 2015, at 6:49 PM, Hengne Li notifications@github.com wrote:

@davidlange6 , the new one 1337 'SMS-T1tttt_mGl-1500_mLSP-100_13' is designed to replace the old one 1337.1 'LM1_sfts_13', i.e. as Giovanni commented behind the following line:

https://github.com/hengne/cmssw/blob/from-CMSSW_7_5_0_pre4_relval_forMerge/Configuration/PyReleaseValidation/python/relval_steps.py#L390

" #steps['LM1_sfts_13INPUT']={'INPUT':InputInfo(dataSet='/RelValLM1_sfts_13/%s/GEN-SIM'%(baseDataSetRelease[3],),location='STD')}# to be removed, replaced by the following"

—
Reply to this email directly or view it on GitHub.

[hengne]

@davidlange6 let's temporarily keep it here, i will remove them once the
validation of the new workflow samples looks fine. So far, we don't have it
even produced because of this bug.

On Tue, May 12, 2015 at 6:50 PM, David Lange notifications@github.com
wrote:

ok - could we just get rid of the lines altogether? Seems they won’t come
back.

On May 12, 2015, at 6:49 PM, Hengne Li notifications@github.com
wrote:

@davidlange6 , the new one 1337 'SMS-T1tttt_mGl-1500_mLSP-100_13' is
designed to replace the old one 1337.1 'LM1_sfts_13', i.e. as Giovanni
commented behind the following line:

https://github.com/hengne/cmssw/blob/from-CMSSW_7_5_0_pre4_relval_forMerge/Configuration/PyReleaseValidation/python/relval_steps.py#L390

"
#steps['LM1_sfts_13INPUT']={'INPUT':InputInfo(dataSet='/RelValLM1_sfts_13/%s/GEN-SIM'%(baseDataSetRelease[3],),location='STD')}#
to be removed, replaced by the following"

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#9026 (comment).

[davidlange6]

+1

Not sure the motivation to keep old not working lines. But ok. Please remember to clean up soon.

On May 12, 2015, at 6:55 PM, Hengne Li <notifications@github.commailto:notifications@github.com> wrote:

@davidlange6 let's temporarily keep it here, i will remove them one the
validation of the new workflow samples looks fine. So far, we don't have it
even produced because of this bug.

On Tue, May 12, 2015 at 6:50 PM, David Lange <notifications@github.commailto:notifications@github.com>
wrote:

ok - could we just get rid of the lines altogether? Seems they won’t come
back.

On May 12, 2015, at 6:49 PM, Hengne Li <notifications@github.commailto:notifications@github.com>
wrote:

@davidlange6 , the new one 1337 'SMS-T1tttt_mGl-1500_mLSP-100_13' is
designed to replace the old one 1337.1 'LM1_sfts_13', i.e. as Giovanni
commented behind the following line:

https://github.com/hengne/cmssw/blob/from-CMSSW_7_5_0_pre4_relval_forMerge/Configuration/PyReleaseValidation/python/relval_steps.py#L390

"
#steps['LM1_sfts_13INPUT']={'INPUT':InputInfo(dataSet='/RelValLM1_sfts_13/%s/GEN-SIM'%(baseDataSetRelease[3],),location='STD')}#
to be removed, replaced by the following"

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#9026 (comment).

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/9026#issuecomment-101346939.