Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed function static to be const in ExpressionVar #9063

Merged

Conversation

Dr15Jones
Copy link
Contributor

The static analyzer complained that a function local static in ExpressionVar was not safe. Converting the variable to const stopped the complaint.

The static analyzer complained that a function local static in
ExpressionVar was not safe. Converting the variable to const
stopped the complaint.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_5_X.

Changed function static to be const in ExpressionVar

It involves the following packages:

CommonTools/Utils

@nclopezo, @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #9063 c2c50ff

Tiny code fix to support multi-threading. It should not affect any monitored quantities.

The code change is satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-05-12-2300 show no significant differences, as expected.

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants