Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consumes interface for TrackerHitAssociator(RECO) #9093

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented May 14, 2015

This PR modifies uses of TrackerHitAssocator to use the consumes interface needed for multithreading. This PR is for packages in the Reco L2 category.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_5_X.

Use consumes interface for TrackerHitAssociator(RECO)

It involves the following packages:

RecoLocalTracker/SiStripClusterizer
RecoLocalTracker/SubCollectionProducers
RecoPixelVertexing/PixelLowPtUtilities
RecoTracker/DebugTools

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @nickmccoll, @makortel, @forthommel, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @appeltel, @mschrode, @jlagram, @gpetruc, @cerati, @threus, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented May 16, 2015

+1

for #9093 756df63

  • changes in the code introduce, as expected, the consumesCollector info for TrackerHitAssociator
  • jenkins tests complete OK and comparisons with baseline show no difference

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants