Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing import script for HBHENegativeEFilter #9105

Merged
merged 1 commit into from May 16, 2015
Merged

Fixing import script for HBHENegativeEFilter #9105

merged 1 commit into from May 16, 2015

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 15, 2015

This PR adds the possibility for the conddb_import tool to fetch and import the class HBHENegativeEFilter. This is needed for the dropbox to properly handle the payloads of this type.

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone May 15, 2015
@mmusich
Copy link
Contributor Author

mmusich commented May 15, 2015

@igv4321 you might want to monitor this as well

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_7_5_X.

Fixing import script for HBHENegativeEFilter

It involves the following packages:

CondCore/Utilities

@ggovi, @cmsbuild, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1 this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor Author

mmusich commented May 15, 2015

@cmsbuild please test

@ggovi
Copy link
Contributor

ggovi commented May 15, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9105/12/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request May 16, 2015
@cmsbuild
Merge pull request #9105 from mmusich/fixCondDBImportScriptHBHENegati…
f0cd4c4 
…veEnergyFilter

Fixing import script for HBHENegativeEFilter
@cmsbuild cmsbuild merged commit f0cd4c4 into cms-sw:CMSSW_7_5_X May 16, 2015
@igv4321 igv4321 mentioned this pull request May 18, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mmusich @cmsbuild @ggovi @davidlange6