New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New mixed triplet seed layers and updates to MVA selectors #9119
Merged
davidlange6
merged 37 commits into
cms-sw:CMSSW_7_5_X
from
mhwalker:newMixedTripletSeedLayers
May 30, 2015
Merged
New mixed triplet seed layers and updates to MVA selectors #9119
davidlange6
merged 37 commits into
cms-sw:CMSSW_7_5_X
from
mhwalker:newMixedTripletSeedLayers
May 30, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elless, fix res_par
…elless, fix res_par
A first look to the comparison shows changes as expected: we are now removing many more 3-5 hits tracks in particular in the overlap region. High statistics relval are of course required. |
+1 for #9119 870ce2c
|
davidlange6
added a commit
that referenced
this pull request
May 30, 2015
New mixed triplet seed layers and updates to MVA selectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small change to the mixed triplet seed layers to become consistent with the detached triplet seed layers and cuts.
There are also updates to improve the behavior of the MVA selectors. Changes were made to make the MVA calculated for each selector as opposed to for each iteration. We added pT as a variable to the MVA. Support for two sets of MVA variables was added. "Prompt" MVA includes d0 and dz infomation. "Detached" MVA does not, which is the same as the previous version. We also changed the way vertex matching is done: if a track has weight for a vertex, it is associated to that vertex; otherwise it is associated to the nearest in dz. A couple minor bug fixes were made as well.
This PR will have to accompany a new payload for the MVA.
The changes will be discussed in the TRK POG meeting on 18 May (sorry for the late notice).