Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding DB - config factor comparison to reader for SiPixelDynamicInefficiency #9132

Merged

Conversation

bartokm
Copy link
Contributor

@bartokm bartokm commented May 18, 2015

No structural changes, just including a DB - config comparison code, which verifies the DB content to previously used config file content.

Adding 13TeV 25ns config file factors to the SiPixelDynamicInefficiencyReader and make a comparison to factors stored in the DB.

Adding 13TeV 25ns v1 factors as standard in the sqlite creating config 'SiPixelDynamicInefficiencyDB_cfg.py'.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bartokm for CMSSW_7_5_X.

Adding DB - config factor comparison to reader for SiPixelDynamicInefficiency

It involves the following packages:

CondTools/SiPixel

@ggovi, @cmsbuild, @nclopezo can you please review it and eventually sign? Thanks.
@apfeiffer1, @dkotlins, @VinInn this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ggovi
Copy link
Contributor

ggovi commented May 19, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request May 19, 2015
…r_update

Adding DB - config factor comparison to reader for SiPixelDynamicInefficiency
@cmsbuild cmsbuild merged commit 1395e43 into cms-sw:CMSSW_7_5_X May 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants